Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elf::tests::zig_host_app failure on NixOS #4180

Closed
Anton-4 opened this issue Oct 3, 2022 · 0 comments · Fixed by #6042
Closed

elf::tests::zig_host_app failure on NixOS #4180

Anton-4 opened this issue Oct 3, 2022 · 0 comments · Fixed by #6042
Labels
bug Something isn't working

Comments

@Anton-4
Copy link
Collaborator

Anton-4 commented Oct 3, 2022 

> cargo test --locked --release elf
[...]
test elf::tests::zig_host_app ... FAILED

failures:

---- elf::tests::zig_host_app stdout ----
thread 'elf::tests::zig_host_app' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }', crates/linker/src/elf.rs:1680:14
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
@Anton-4 Anton-4 added the bug Something isn't working label Oct 3, 2022
@Anton-4 Anton-4 mentioned this issue Nov 17, 2023
Merged
jecaro added a commit to jecaro/roc that referenced this issue Nov 21, 2023
@jecaro
Fix zig_host_app on NixOS
d21ea2e 
That's a problem with the dynamic loader:
https://discourse.nixos.org/t/no-such-file-of-directory-when-trying-to-execute-binary-file/6150

When linking `libapp.so` with `host.zig`, zig puts in the binary the
standard path for the dynamic loader on linux:
`/lib64/ld-linux-x86-64.so.2`

However in NixOS, that file is somewhere else in the nix store (see:
https://nixos.wiki/wiki/Packaging/Binaries#The_Dynamic_Loader). Removing
the `-target` switch makes zig uses the host target for linking and puts
the right path to the dynamic loader in the resulting binary. As we want
to execute that binary file in this test, it makes sense to use the
default target anyway.

Note that this is relevant for the creation of the binary only. For the
creation of the object file, it doesn't really matter. But I removed the
`-target` switch as well there for consistency.

Fix roc-lang#4180
@jecaro jecaro mentioned this issue Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix zig_host_app on NixOS jecaro/roc
1 participant
@Anton-4