Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scalars and graphemes from Str #6395

Merged
merged 11 commits into from
Jan 21, 2024
Merged

Remove scalars and graphemes from Str #6395

merged 11 commits into from
Jan 21, 2024

Conversation

rtfeldman
Copy link
Contributor

As the new docs for Str explain, these operations now live in roc-lang/unicode.

Notably, this will mean roc-json will need to not use Str.graphemes and instead do capitalization of ASCII characters using UTF-8 bytes directly (which should actually improve performance too!)

@lukewilliamboswell
Copy link
Collaborator

I thought I fixed it, checked the wrong this to test. I should have ran bash www/build.sh

@rtfeldman
Copy link
Contributor Author

@lukewilliamboswell I ended up special-casing "»" in the highlighter so it accepts it at the start of a code snippet, so we can just put repl snippets in there now.

Copy link
Collaborator

@lukewilliamboswell lukewilliamboswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants