Redesign #42
Merged
Redesign #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
valeryhime
commented
Jan 22, 2023
•
valeryhime
commented
- The main Activity split into two tabs
- Added Fragments for Sender and Receiver tabs
- "Use playback capture" checkbox replaced with select
- Created copyable block for ports and IP addresses
- Plain text with instructions replaced with list of instructions
- Used colors from Roc icon
- Added playing status for sender and receiver tabs
- Added logs
|
|
|
Hi @valeryhime ! It looks great! Could you please:
And I'll look closely in upcoming times 😄 |
|
Hi @ortex! Done ^_^ |
|
Here many changes with android UI and I'm not great with it, but added a few minor code-related comments :) |
ortex
reviewed
Jan 26, 2023
app/src/main/java/org/rocstreaming/rocdroid/fragment/SenderFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/rocstreaming/rocdroid/fragment/SenderFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/rocstreaming/rocdroid/fragment/SenderFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/rocstreaming/rocdroid/fragment/SenderFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/rocstreaming/rocdroid/fragment/SenderFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/rocstreaming/rocdroid/fragment/ReceiverFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/rocstreaming/rocdroid/adapter/ViewPagerAdapter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/rocstreaming/rocdroid/component/CopyBlock.kt
Outdated
Show resolved
Hide resolved
|
And could you please update screenshots in readme? 😄 |
ortex
reviewed
Jan 27, 2023
app/src/main/java/org/rocstreaming/rocdroid/fragment/SenderFragment.kt
Outdated
Show resolved
Hide resolved
|
LGTM! |
gavv
approved these changes
Jan 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.