-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add error handling in go2cStr #55
Conversation
LGTM. But, it would be great to add tests for endpoint, to cover new branches. For sender and receiver there are separate issues |
Minor comment: when we're forwarding error from go2cStr, like this:
it'd be nice to wrap the returned error and explain what string was invalid (otherwise it would be hard to guess for user). Like:
|
The linux build in CI uses go 1.12 which doesn't support "%w" to wrap errors, so I had to replace it with "%v". |
I think we can bump minimum go to 1.13 (in go mod and .github/workflows). The choice of 1.12 with rather arbitrary (it just was known to work on 1.12). On the other hand, I'd say |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for update! A couple more (I think final) comments.
Signed-off-by: Piotr Lewandowski <lewandowski323@gmail.com>
Signed-off-by: Piotr Lewandowski <lewandowski323@gmail.com>
I rebased onto main because endpoint tests were refactored and updated the changes according to your comments. |
Thanks!! |
fixes #50