Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for sender, receiver open errors #68

Merged
merged 3 commits into from
Mar 29, 2023

Conversation

ortex
Copy link
Member

@ortex ortex commented Mar 28, 2023

#67

@coveralls
Copy link
Collaborator

coveralls commented Mar 28, 2023

Coverage Status

Coverage: 87.335% (+1.5%) from 85.822% when pulling b7608bc on ortex:sender-receiver-open-test-errors into e4be31a on roc-streaming:main.

@ortex ortex added the ready for review Pull request can be reviewed label Mar 28, 2023
@gavv gavv linked an issue Mar 29, 2023 that may be closed by this pull request
@gavv
Copy link
Member

gavv commented Mar 29, 2023

We could nicely merge new tests into TestXxx_Open by adding context creation func to the table:

		{
			name:    "closed context",
			...
			contextFunc: func() *Context {
				ctx, err := OpenContext()
				ctx.Close()
				return ctx
			},
		},

WDYT?

@ortex ortex force-pushed the sender-receiver-open-test-errors branch from 7cdba67 to c7483db Compare March 29, 2023 14:15
roc/receiver_test.go Outdated Show resolved Hide resolved
roc/receiver_test.go Outdated Show resolved Hide resolved
@gavv gavv added needs revision Pull request should be revised by its author and removed ready for review Pull request can be reviewed labels Mar 29, 2023
@gavv gavv merged commit 3e54e9b into roc-streaming:main Mar 29, 2023
@gavv
Copy link
Member

gavv commented Mar 29, 2023

LGTM!

@gavv gavv removed the needs revision Pull request should be revised by its author label Mar 29, 2023
@ortex ortex deleted the sender-receiver-open-test-errors branch March 30, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve receiver and sender test coverage
3 participants