Issue 85: Use time.Time for encoding LogMessage.Time instead of uint64 #89
Conversation
…djusted the testcases to check if time is not zero - Removed the redudant error check in reciver.go as golint suggested
|
Hi, thanks for PR! LGTM.
AFAIK, we don't have such linter enabled, and the code base doesn't follow the suggested code style, so could you please roll back that part? I personally prefer the existing code style, too - every error checking block looks the same no matter if it's the last one or not. With this approach, you can easily reorder blocks or add a new one to the end. With the suggested approach, the last block always requires special handling, which is annoying. |
as for the linter, that was the |
|
Oh, I see, thanks. CI uses 1.51.2 What version do you use? If you're using a later one, I guess we'll need to adjust the linter config and bump it on CI, too. If you're using an older one, you can just update yours. |
Mine is 1.52.2 but it is built with go1.20.2, as I have that version of go installed locally and I forgot to install linter from the go1.13 |
|
A fix for linter was merged in #90. BTW, welcome to matrix chat of the project! https://roc-streaming.org/toolkit/docs/about_project/contacts.html#matrix-chats |
PR for Use time.Time for LogMessage.Time #85
CHANGED the LogMeesage.Time encoding from uint64 to time.Time and And adjusted the testcases to check if time is not zero
Removed the redudant error check in reciver.go as linter suggested