Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Freeze libroc version when building AAR on CI #112

Open
gavv opened this issue May 14, 2023 · 0 comments
Open

Freeze libroc version when building AAR on CI #112

gavv opened this issue May 14, 2023 · 0 comments
Labels
android Android-related tasks continuous integration Continuous integration good first issue Good for newcomers help wanted Contributions are welcome

Comments

@gavv
Copy link
Member

gavv commented May 14, 2023 •
edited
Loading

Currently, when CI builds AAR, it uses libroc from master branch of roc-toolkit. It's not good because this way AAR builds are not reproducible.

What we need to do:

  • add ROC_VERSION parameter to android_docker.sh script; default value should be "master"; when cloning roc, checkout specified version

  • in release job on CI, specify ROC_VERSION explicitly, set it to roc-toolkit tag which is currently the latest

ROC_VERSION should support any git revision notation: tag name, branch name, or commit hash.
@gavv gavv added good first issue Good for newcomers help wanted Contributions are welcome continuous integration Continuous integration android Android-related tasks labels May 14, 2023
@gavv gavv mentioned this issue May 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
android Android-related tasks continuous integration Continuous integration good first issue Good for newcomers help wanted Contributions are welcome
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gavv