Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Freeze libroc version when building AAR on CI #112

Closed
gavv opened this issue May 14, 2023 · 1 comment
Closed

Freeze libroc version when building AAR on CI #112

gavv opened this issue May 14, 2023 · 1 comment
Assignees
@gavv
Labels
android Android-related tasks continuous integration Continuous integration

Comments

@gavv
Copy link
Member

gavv commented May 14, 2023 •
edited
Loading

Currently, when CI builds AAR, it uses libroc from master branch of roc-toolkit. It's not good because this way AAR builds are not reproducible.

What we need to do:

  • add ROC_VERSION parameter to android_docker.sh script; default value should be "master"; when cloning roc, checkout specified version

  • in release job on CI, specify ROC_VERSION explicitly, set it to roc-toolkit tag which is currently the latest

ROC_VERSION should support any git revision notation: tag name, branch name, or commit hash.
@gavv gavv added good first issue Good for newcomers help wanted Contributions are welcome continuous integration Continuous integration android Android-related tasks labels May 14, 2023
@gavv gavv mentioned this issue May 14, 2023
Closed
@gavv gavv removed good first issue Good for newcomers help wanted Contributions are welcome labels Oct 12, 2024
@gavv gavv self-assigned this Oct 12, 2024
gavv added a commit to gavv/roc-java that referenced this issue Oct 12, 2024
@gavv
Build & CI fixes
f034175 
Closes: roc-streaming#72, roc-streaming#112, roc-streaming#116, roc-streaming#106, roc-streaming#107, roc-streaming#105

- Update requirements:
    for build: JDK 17+
    for running: JRE 8+
    Android API 29+ (Android 10)

- Bump gradle version and fix build on recent JDK versions

- CI:
    bump actions versions
    cleanup
    test JDK 21 and JDK 17
    switch to android-actions/setup-android
    downgrade roc-toolkit from master to v0.2.6
    automatically select best roc-toolkit git tag for release AAR

- README:
    document version requirements
    cleanup build & devel instructions
    document where versions are hard-coded

- Gradle:
    use io.freefair.android-lombok on Android
    run delombok before javadoc
    disable javadoc warnings
    switch from "maven" to "maven-publish" plugin
    fix cmake warnings due to incorrect invocation

- Sources:
    fix javadoc errors
    exclude gradle code from javadoc
gavv added a commit to gavv/roc-java that referenced this issue Oct 12, 2024
@gavv
Build & CI fixes
2e75b81 
Closes: roc-streaming#72, roc-streaming#112, roc-streaming#116, roc-streaming#106, roc-streaming#107, roc-streaming#105

- Update requirements:
    for build: JDK 17+
    for running: JRE 8+
    Android SDK: 31+ (Android 12)
    Android API: 29+ (Android 10)

- Bump gradle version and fix build on recent JDK versions

- CI:
    bump actions versions
    cleanup
    test JDK 21 and JDK 17
    switch to android-actions/setup-android
    downgrade roc-toolkit from master to v0.2.6
    automatically select best roc-toolkit git tag for release AAR

- README:
    document version requirements
    cleanup build & devel instructions
    document where versions are hard-coded

- Gradle:
    use io.freefair.android-lombok on Android
    run delombok before javadoc
    disable javadoc warnings
    switch from "maven" to "maven-publish" plugin
    fix cmake warnings due to incorrect invocation

- Sources:
    fix javadoc errors
    exclude gradle code from javadoc
@gavv gavv mentioned this issue Oct 12, 2024
Merged
gavv added a commit to gavv/roc-java that referenced this issue Oct 12, 2024
@gavv
Build & CI fixes
3a9c0e9 
Closes: roc-streaming#72, roc-streaming#112, roc-streaming#116, roc-streaming#106, roc-streaming#107, roc-streaming#105

- Update requirements:
    for build: JDK 17+
    for running: JRE 8+
    Android SDK: 31+ (Android 12)
    Android API: 29+ (Android 10)

- Bump gradle version and fix build on recent JDK versions

- CI:
    bump actions versions
    cleanup
    test JDK 21 and JDK 17
    switch to android-actions/setup-android
    downgrade roc-toolkit from master to v0.2.6
    automatically select best roc-toolkit git tag for release AAR

- README:
    document version requirements
    cleanup build & devel instructions
    document where versions are hard-coded

- Gradle:
    use io.freefair.android-lombok on Android
    run delombok before javadoc
    disable javadoc warnings
    switch from "maven" to "maven-publish" plugin
    fix cmake warnings due to incorrect invocation

- Sources:
    fix javadoc errors
    exclude gradle code from javadoc
gavv added a commit to gavv/roc-java that referenced this issue Oct 12, 2024
@gavv
Build & CI fixes
d9f6768 
Closes: roc-streaming#72, roc-streaming#112, roc-streaming#116, roc-streaming#106, roc-streaming#107, roc-streaming#105

- Update requirements:
    for build: JDK 17+
    for running: JRE 8+
    Android SDK: 31+ (Android 12)
    Android API: 29+ (Android 10)

- Bump gradle version and fix build on recent JDK versions

- CI:
    bump actions versions
    cleanup
    test JDK 21 and JDK 17
    switch to android-actions/setup-android
    downgrade roc-toolkit from master to v0.2.6
    automatically select best roc-toolkit git tag for release AAR

- README:
    document version requirements
    cleanup build & devel instructions
    document where versions are hard-coded

- Gradle:
    use io.freefair.android-lombok on Android
    run delombok before javadoc
    disable javadoc warnings
    switch from "maven" to "maven-publish" plugin
    fix cmake warnings due to incorrect invocation

- Sources:
    fix javadoc errors
    exclude gradle code from javadoc
gavv added a commit to gavv/roc-java that referenced this issue Oct 15, 2024
@gavv
Build & CI fixes
11fff31 
Closes: roc-streaming#72, roc-streaming#112, roc-streaming#116, roc-streaming#106, roc-streaming#107, roc-streaming#105

- Update requirements:
    for build: JDK 17+
    for running: JRE 8+
    Android SDK: 31+ (Android 12)
    Android API: 29+ (Android 10)

- Bump gradle version and fix build on recent JDK versions

- CI:
    bump actions versions
    cleanup
    test JDK 21 and JDK 17
    switch to android-actions/setup-android
    downgrade roc-toolkit from master to v0.2.6
    automatically select best roc-toolkit git tag for release AAR

- README:
    document version requirements
    cleanup build & devel instructions
    document where versions are hard-coded

- Gradle:
    use io.freefair.android-lombok on Android
    run delombok before javadoc
    disable javadoc warnings
    switch from "maven" to "maven-publish" plugin
    fix cmake warnings due to incorrect invocation

- Sources:
    fix javadoc errors
    exclude gradle code from javadoc
gavv added a commit that referenced this issue Oct 16, 2024
@gavv
Build & CI fixes
8f85b10 
Closes: #72, #112, #116, #106, #107, #105

- Update requirements:
    for build: JDK 17+
    for running: JRE 8+
    Android SDK: 31+ (Android 12)
    Android API: 29+ (Android 10)

- Bump gradle version and fix build on recent JDK versions

- CI:
    bump actions versions
    cleanup
    test JDK 21 and JDK 17
    switch to android-actions/setup-android
    downgrade roc-toolkit from master to v0.2.6
    automatically select best roc-toolkit git tag for release AAR

- README:
    document version requirements
    cleanup build & devel instructions
    document where versions are hard-coded

- Gradle:
    use io.freefair.android-lombok on Android
    run delombok before javadoc
    disable javadoc warnings
    switch from "maven" to "maven-publish" plugin
    fix cmake warnings due to incorrect invocation

- Sources:
    fix javadoc errors
    exclude gradle code from javadoc
@gavv
Copy link
Member Author

gavv commented Oct 16, 2024

Fixed via #132.

@gavv gavv closed this as completed Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gavv gavv

Labels
android Android-related tasks continuous integration Continuous integration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gavv