Skip to content
This repository has been archived by the owner on Mar 9, 2021. It is now read-only.

stringify patch values -- DO NOT MERGE, BREAKING CHANGE #55

Closed
wants to merge 1 commit into from

Conversation

phritz
Copy link
Contributor

@phritz phritz commented Aug 26, 2020

fixes #54

@vercel
Copy link

vercel bot commented Aug 26, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/rocicorp/diff-server/dnspy04sv
✅ Preview: https://diff-server-git-patch.rocicorp.vercel.app

@phritz
Copy link
Contributor Author

phritz commented Aug 26, 2020

@aboodman here's our first demonstration that we need versioning of our rpcs: if we merge this it gets pushed to production and immediately breaks existing clients in the wild. what we want to do is introduce a new field we can use if the client understands it, else use the old field (until such time as we expire old clients in the wild and then we can do away with it). we can't return both because it halves the size of the client view we can return.

for now, i'm going to introduce a version field in pullrequest and return the old encoding if 0 and the new encoding if 1. i also filed rocicorp/repc#119

@phritz phritz changed the title stringify patch values -- BREAKING CHANGE stringify patch values -- DO NOT MERGE, BREAKING CHANGE Aug 26, 2020
@phritz
Copy link
Contributor Author

phritz commented Aug 27, 2020

closing in favor of #56

@phritz phritz closed this Aug 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embed payload as string rather than directly in JSON to allow client to treat it opaquely
1 participant