This repository has been archived by the owner on Sep 3, 2021. It is now read-only.
Add overlappingRequests flag to "open" #329
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arv
force-pushed
the
overlapping-requests
branch
from
0853650
to
e0c9512
Compare
When overlappingRequests is true it is in an error if the pull/push endpoint uses HTTP1/x. It needs to use H2 or H3. fetch/rust_client.rs is not really working with this change since it uses hyper 0.13 which does not support HTTP/2. There is a newer version of hyper that supports h2 but hyper runs on top of tokio and we use std async. We have a compat file but I could not get it to work correctly. I need to spend more time on this if we ever want to support non web. I tested the browser fetch path manually. https://www.notion.so/Push-pull-scheduling-268fd33bbcf14c5cbced55a249f409aa#c959432fc61a4c4bb152aa61e3856f44 Towards rocicorp/replicache#294
To share the implementation
arv
force-pushed
the
overlapping-requests
branch
from
e0c9512
to
ba98711
Compare
|
I'll do |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When overlappingRequests is true it is in an error if the pull/push
endpoint uses HTTP1/x. It needs to use H2 or H3.
fetch/rust_client.rs is not really working with this change since it
uses hyper 0.13 which does not support HTTP/2. There is a newer version
of hyper that supports h2 but hyper runs on top of tokio and we use std
async. We have a compat file but I could not get it to work correctly. I
need to spend more time on this if we ever want to support non web.
I tested the browser fetch path manually.
https://www.notion.so/Push-pull-scheduling-268fd33bbcf14c5cbced55a249f409aa#c959432fc61a4c4bb152aa61e3856f44
Towards rocicorp/replicache#294