This repository has been archived by the owner on Sep 3, 2021. It is now read-only.
feat: Move KV Store implementation to JS #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Js Side: rocicorp/replicache#427 |
aboodman
approved these changes
Aug 5, 2021
arv
force-pushed
the
js-store
branch
2 times, most recently
from
28ff3bf
to
893ff51
Compare
arv
changed the title
aboodman
approved these changes
Aug 9, 2021
We keep MemStore for testing but IdbStore is all in JS now. The kv store is passed in as a store key in the OpenRequest This also removes `rollback` since we do not need to do anything to rollback.
arv
added a commit
that referenced
this pull request
Aug 9, 2021
We keep MemStore for testing but IdbStore is all in JS now. The kv store is passed in as a store key in the OpenRequest This also removes `rollback` since we do not need to do anything to rollback.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We keep MemStore for testing but IdbStore is all in JS now.
The kv store is passed in as a
storekey in theOpenRequest