This repository has been archived by the owner on Sep 3, 2021. It is now read-only.
Add schema for db package! #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@phritz I used the nomenclature from your most recent design doc changes. I still don't have a better name for this layer than db, suggestions welcome. |
|
Just wanted to point out It's interesting (but I guess makes sense) that neither |
phritz
reviewed
Jul 13, 2020
| @@ -0,0 +1,32 @@ | |||
| namespace commit; | |||
|
|
|||
| table LocalMeta { | |||
There was a problem hiding this comment.
can we put comments in the definition files? if so I think it would be helpful. f
|
Comments addressed in 8a3713a |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉
I just wanted to write this out. Feels good to be back up to the top level.