Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename JsonType to JSONType #11

Closed
arv opened this issue Jun 5, 2020 · 0 comments · Fixed by #16
Closed

Rename JsonType to JSONType #11

arv opened this issue Jun 5, 2020 · 0 comments · Fixed by #16

Comments

@arv
Copy link
Contributor

arv commented Jun 5, 2020

We should try to match these rules in our JS API:

https://w3ctag.github.io/design-principles/#casing-rules
arv added a commit to arv/replicache that referenced this issue Jun 9, 2020
@arv
Rename JsonType to JSONValue
cdb59fd 
Fixes rocicorp#11
Fixes rocicorp#12
@arv arv mentioned this issue Jun 9, 2020
Merged
arv added a commit to arv/replicache that referenced this issue Jun 9, 2020
@arv
Rename JsonType to JSONValue
867531c 
Fixes rocicorp#11
Fixes rocicorp#12
@arv arv closed this as completed in #16 Jun 9, 2020
arv added a commit that referenced this issue Jun 9, 2020
@arv
Rename JsonType to JSONValue
42db3a2 
Fixes #11
Fixes #12
aboodman pushed a commit that referenced this issue Oct 28, 2021
@whiten
Implement onupgrade and get/put for idbstore. (#11)
69342df 
This also starts using Rust error techniques as from
https://www.philipdaniels.com/blog/2019/defining-rust-error-types/ to
allow using the ? operator in idbstore.rs rather than match everywhere.
I expect we can move towards something similar in dispatch.rs as well.

Much of the size increase here came in with the simple uses of Serde
that this introduced. I think it would be worthwhile to explore exposing
a function per RPC request to avoid this, but didn't want to bite that
off before sharing this.

replicache_client.js: 16321 (+21%)
replicache_client.js.br: 3531 (+11%)
replicache_client_bg.wasm: 128657 (+147%)
replicache_client_bg.wasm.br: 56310 (+154%)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename JsonType to JSONValue arv/replicache
1 participant
@arv