Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mock out servers in tests #95

Closed
arv opened this issue Sep 17, 2020 · 1 comment · Fixed by #104
Closed

Mock out servers in tests #95

arv opened this issue Sep 17, 2020 · 1 comment · Fixed by #104

Comments

@arv
Copy link
Contributor

arv commented Sep 17, 2020 •
edited
Loading

We currently talk to the live servers during tests. We talk to:

  • https://replicache-sample-todo.now.sh/serve/replicache-batch
  • https://serve.replicache.dev/pull

We should mock these resources
@arv arv changed the title Moch out batchURL in tests Mock out batchURL in tests Sep 17, 2020
@arv
Copy link
Contributor Author

arv commented Sep 17, 2020

https://github.com/rocicorp/replicache-sdk-js/blob/45d3e2f8396f6e8cf8dcd78ecc950cdb58d4e0a9/src/replicache.test.ts#L30

https://github.com/rocicorp/replicache-sdk-js/blob/45d3e2f8396f6e8cf8dcd78ecc950cdb58d4e0a9/src/replicache.test.ts#L486

@arv arv changed the title Mock out batchURL in tests Mock out servers in tests Sep 17, 2020
arv added a commit to arv/replicache that referenced this issue Sep 18, 2020
@arv
Mock fetch in tests
555f4af 
Fixes rocicorp#95
@arv arv mentioned this issue Sep 18, 2020
Merged
@arv arv closed this as completed in #104 Sep 20, 2020
arv added a commit that referenced this issue Sep 20, 2020
@arv
Mock fetch in tests (#104)
ce7a581 
Fixes #95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mock fetch in tests arv/replicache
1 participant
@arv