Make it possible to pass data to templates #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm.. interesting, build failed on a file that I haven't touched. Not reproducable locally yet, but I'll keep trying 🤔 |
dlmr
requested changes
Apr 5, 2017
docs/Templates.md
Outdated
| @@ -161,6 +161,19 @@ The `prompts` property follows [Inquirer.js](https://github.com/SBoudrias/Inquir | |||
|
|
|||
| `name` and `author` are a bit special and will automatically default to the directory name and, if available, the name from the git config. | |||
|
|
|||
| #### `data` | |||
There was a problem hiding this comment.
This section should be below ##### 'when'.
docs/Templates.md
Outdated
| { | ||
| "data": { | ||
| "version": "1.0.2", | ||
| "recentChanges": fetch("https://some-changelog.org/recent") |
There was a problem hiding this comment.
Given how the code is structured this example should be:
"recentChanges": () => fetch("https://some-changelog.org/recent")| /* eslint-disable no-param-reassign */ | ||
| if (typeof dataProvider === 'function') { | ||
| try { | ||
| metadata[key] = await dataProvider(); |
There was a problem hiding this comment.
What do you think about passing in the metadata here, into dataProvider()?
Then we could get access to the answers that the user has answered.
// Provide metadata
await dataProvider(metadata);
// Later we can use it
"recentChanges": (answers) => fetch("https://some-changelog.org/recent")If we do this change we should also add a comment about it in the documentation.
dlmr
approved these changes
Apr 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ability to pass additional data to templates that cannot or should not be obtained with questions.
My particular case is: I have a template inside of a module and I'd like to get that module's version from
package.json.