PSO: Add param file output; PSO,CMAES: Add param rescaling py-scripts & Bugfix issue #49 #48
Conversation
|
@malter This is probably something you should review. I can only say some things regarding Python code. |
| @@ -0,0 +1,38 @@ | |||
| #!/bin/python | |||
There was a problem hiding this comment.
How is evalCMAESOutput.py different from evalPSOOutput.py?
There was a problem hiding this comment.
CMAES and PSO output files have different formats. Each script matches the corresponding format.
| import sys | ||
| import os | ||
| import numpy as np | ||
|
|
There was a problem hiding this comment.
Please use PEP8 style for Python: https://www.python.org/dev/peps/pep-0008/
There are command line tools that you can use to check compliance.
| else: | ||
| print "ERROR: Number of parameters do not match!" | ||
| else: | ||
| print "Failed. Usage: python evalCMAESOutput.py $allcmaes.dat $param.yml $output_parameters.yml" |
There was a problem hiding this comment.
Please write code that is compatible with Python 2 and 3 because we will probably have to switch to Python 3 soon. In this case: print(...) instead of print ....
|
The last commit fixes issue #49 |
hwiedPro
changed the title
|
Looks good to me. It is usually better to split this up into two pull requests. I don't see any problems with the first part of the pull request though. I will merge this now. |
|
One more thing: could you document the purpose of the scripts a little bit? You can add a comment at the beginning of the scripts. |
Adding python scripts that turn the unscaled optimizer outputs back into the scaled values. Afterwards they write them in a "start_parameters.yml" compatible format.
Therefore added file output of the parameters to the pso_optimizer.