Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the latest Ubuntu image to run tests and coveralls #10

Merged
merged 2 commits into from
Aug 22, 2022

Conversation

Senen
Copy link
Member

@Senen Senen commented Aug 22, 2022

References

Port from CONSUL:

Tests and coveralls workflows stopped working since Github Action has deprecated the Ubuntu 18.04 image.

Objectives

Run the latest Ubuntu image, so we do not have to update the workflow each time the system we use becomes deprecated.

@Senen Senen self-assigned this Aug 22, 2022
nathannaveen and others added 2 commits August 22, 2022 17:20
 Restrict the GitHub token permissions only to the required ones; this way, even if the attackers will succeed in compromising your workflow, they won’t be able to do much.

- Included permissions for the action. https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions

https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs

[Keeping your GitHub Actions and workflows secure Part 1: Preventing pwn requests](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/)

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
It is the Ubuntu 20.04 version at the time of writing.

Github Actions has deprecated the 18.04 we were using.
@Senen Senen force-pushed the update_tests_and_coveralls_ubuntu_image branch from 6ba40b1 to 62e9498 Compare August 22, 2022 15:21
@Senen Senen marked this pull request as ready for review August 22, 2022 15:21
@Senen Senen changed the title Use the latest available Ubuntu image to run tests Use the latest Ubuntu image to run tests and coveralls Aug 22, 2022
@Senen Senen merged commit ae99427 into stable Aug 22, 2022
@Senen Senen deleted the update_tests_and_coveralls_ubuntu_image branch August 22, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants