apply timeouts to rewards tree downloads #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggest reviewing with whitespace hidden:
The diff becomes very small:
Timeouts are needed because we don't set one locally, so golang will not timeout ever. Fortunately the ipfs services seem to cut us off and 504 after 1-2 minutes (each).
This means that if both ipfs services are failing (as they are for @xrchz), we never time out, but instead get 504 responses, back to back, and downloading each file takes over 2 minutes.
Instead we can start by trying to download the files with a very short timeout and then extend it a couple times if it fails.