Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix voluntary exit signatures #447

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Conversation

0xfornax
Copy link
Member

@0xfornax 0xfornax commented Feb 15, 2024

Fix the exit signatures as they were failing after the Dencun upgrade on Holesky.
Always using the CAPELLA_FORK_VERSION when computing the domain for the voluntary exit signature.
Domain() function was deprecated so it was replaced by ComputeDomain()

@jshufro
Copy link
Contributor

jshufro commented Feb 15, 2024

will this work on mainnet? what happens when the CAPELLA_FORK_VERSION field is null, eg on a pre-capella testnet?

@0xfornax
Copy link
Member Author

will this work on mainnet? what happens when the CAPELLA_FORK_VERSION field is null, eg on a pre-capella testnet?

Yes, on mainnet the signature uses the current fork version (which is also Capella).
I don't think it's worth trying to support past forks and also don't see the benefits of running such forks on testnets as they don't allow us to replicate the production environment.

@0xfornax 0xfornax merged commit 3abc4a9 into master Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants