fix: support for using alerting in native mode #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds a new Alertmanger host config that is only used in native mode - The AlertingConfigPage is was made reusable so it works in both native mode config and docker config - Fixes rocket-pool#462
jclapis
reviewed
Mar 20, 2024
…ters for native-mode/docker mode - per code review feedback
… per code review feedback
|
@jclapis Thanks for the review. I resolved your feedback. |
|
Alright, thanks for the updates. Let's give it a test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes [alerting]
rocketpool node statusshould not fail if alert manager can't be reached #462fixes [alerting] Alert manager should have an explicit enable option, so you can have metrics w/o alerts and vice versa #463
Related to rocket-pool/docs.rocketpool.net#79
Keeping this a draft pending: