Dcode/suricata pipeline #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcode
requested changes
May 16, 2020
ecs-configuration/logstash/pipelines/suricata/logstash-601-filter-suricata-fileinfo.conf
Outdated
Show resolved
Hide resolved
ecs-configuration/logstash/pipelines/suricata/logstash-601-filter-suricata-fileinfo.conf
Outdated
Show resolved
Hide resolved
ecs-configuration/logstash/pipelines/suricata/logstash-601-filter-suricata-smb.conf
Outdated
Show resolved
Hide resolved
ecs-configuration/logstash/pipelines/suricata/logstash-601-filter-suricata-smb.conf
Outdated
Show resolved
Hide resolved
ecs-configuration/logstash/pipelines/suricata/logstash-601-filter-suricata-smb.conf
Show resolved
Hide resolved
Comment on lines
+11
to
+12
| "[smb][share]" => "[file][path]" | ||
| "[smb][share_type]" => "[file][type]" |
There was a problem hiding this comment.
These are smb share specific, so maybe let's leave these for now. the file.path would be relative to the share, so it's like two different paths to combine to really find the file.
There was a problem hiding this comment.
Not sure what you are asking to be done with this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.