-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Weather Provider (Qweather.com) #68
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Good work.. I Took a quick look and here is what I think:
The WMO code is important and care needs to be taken because it is used for all the effects and other core features. |
|
Revert the changes in Rest looks fine but is the CLA a problem? noticed you haven't signed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provider uses the free subscription of Qweather.com and needs an API key.
First, only 24-hour hourly weather data can be provided. which means the hourly graph (e.g. temp, uv, aqi ...) can only work properly for the current day.
Second, this is the only provider that can provide as much data as we need as possible in mainland China when it's free.
And I don't think we can merge data from multiple providers to this provider:
regional specificity: network vpn blahblahblah...
different provider means different API keys (there is no public(gov) service of weather in the China network), I don't think this is acceptable when I using just a weather app, because of that I need to input more than one API key.
Last, i don't know if this pull request is helpful.
There is also a problem need to be fix if we use this provider because of the lack of the hourly weather data: