Add option to only deploy marked query lambdas. #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhochmuth
commented
Aug 25, 2023
|
|
||
| 1. Limit the number of Query Lambdas that are in your local state. | ||
| 2. Call the deploy command with the `--onlyDeployIfFlagged` option. Calling this command with that flag enabled will cause the CLI to ignore any Query Lambdas that do not have config.flagForDeploy set to true in the local file. You must handle setting this value for each Query Lambda yourself. | ||
|
|
There was a problem hiding this comment.
only readme changes, everything else is formatting
jhochmuth
force-pushed
the
julius_deploy_flag
branch
from
0ce296a
to
653481c
Compare
kristielim
reviewed
Aug 25, 2023
There was a problem hiding this comment.
Is the change that if onlyDeployIfFlagged then QLs will only be deployed if flagForDeploy is set? I'm not sure this is a very easy to use solution, since it can be hard to know what changed.
Can we get all the query lambdas before updating and check if there are any query text changes instead of the flag mechanism? The db read rate limit is more generous so I don't think we'd hit the read rate limit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.