[Issue]: Location of half.hpp

[trixirt]

Problem Description

Same issue as MIOpen

I am packaging rpp for Fedora, the addition of the half/ makes it impossible to set the location of half.hpp in configury.

Operating System

Fedora Rawhide

CPU

x86_64

GPU

AMD Instinct MI210

Other

No response

ROCm Version

ROCm 6.0.0

ROCm Component

rpp

Steps to Reproduce

No response

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

No response

Additional Information

No response

[kiritigowda]

@trixirt we have FindHalf to locate half headers. If you add additional location here -

rpp/cmake/FindHALF.cmake

Line 35 in 2d7adde

${ROCM_PATH}/include

should find the library on your setup.

If you provide Half default on Fedora, I can add it or you can create a PR to make it available for all.

[kiritigowda]

@trixirt were you able to resolve this issue?

[AngryLoki]

@trixirt , I think distro maintainers should install half.hpp into /usr/include/half/. I encountered this issue in Gentoo, and I will update ebuilds there in that way.

Reasoning: https://github.com/ROCm/half is a project under ROCm umbrella. MIOpen, MIVisionX, AMDMIGraphX, rpp, MIFin, rocAL and maybe other ROCm projects just decided to include it as <half/half.hpp>. I see this header in other projects, but again, mostly as <half/half.hpp>.

[kiritigowda]

@trixirt --- With the cmake you can also use the -D HALF_DIRor ENV Variable HALF_DIR to set path to include. If you still face this issue reopen.

-D HALF_DIR /PATH/TO/half/half.hpp

rpp/cmake/FindHALF.cmake

Line 31 in b6f334a

${HALF_DIR}/include

rpp/cmake/FindHALF.cmake

Line 28 in b6f334a

$ENV{HALF_DIR}/include