Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SetRows #16

Merged
merged 4 commits into from
Apr 16, 2021
Merged

Add SetRows #16

merged 4 commits into from
Apr 16, 2021

Conversation

irgendwr
Copy link
Contributor

@irgendwr irgendwr commented Aug 2, 2020

This adds the possibility to directly set rows and also clear them by setting an empty array. This improves efficiency in some use-cases.

Closes #15

@rodaine
Copy link
Owner

rodaine commented Apr 12, 2021

Thanks! Can you add tests to cover this addition?

@irgendwr
Copy link
Contributor Author

In retrospect, I should have put a bit more effort into the pull-request instead of just quickly adding the hack that I needed 😄
This now properly truncates rows that exceed the header length and tests that it behaves as expected.

Copy link
Owner

@rodaine rodaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, again! Looks good. 😁

@rodaine rodaine merged commit a3154d8 into rodaine:master Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: set rows directly
2 participants