Use ng-packagr to pack library #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- it is required by ngc to do the build
- otherwise tsc throws errors concerning renderer3 located in angular/core
|
Hi @rodgc, I just want to ask if there is anything I can help with to get this PR merged and released. Please let me know if I missed something. 👍 Kinds |
|
Will this resolve #36 ? Would love to see it merged if so. This is blocking me from using ngx-socket-io with Ivy. |
|
What's holding up the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @rodgc,
thank you for providing
ngx-socket-io.It provides seamless integration with Socket.IO. 👍
Since my team switched to Jest we experience an issue with ngx-socket-io.
I will create an additional issue for it to get more into detail.
I had a look ad
ngx-socket-ioand noticed that it can benefit fromng-packagra tool also used by the Angular CLI to create and build libraries.I replaced the current ngc-rollup-uglifyjs pipeline with ng-packagr.
Delivering the bundles produced by ng-packagr automatically resolve the issue with Jest.
I am happy if you can have a look at my PR.
Please reach out if any questions occur. 👌