-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MultipartFileRecreatable.fromBytes + plugin improvements #29
Conversation
@rodion-m I noticed running |
@rodion-m do you think this could get reviewed anytime soon? We've been using it in production for a couple months now |
Hello! Sorry for the delay, I was too busy at work. You did a great job, thank you for this. Since your PR makes breaking changes, could you please add information in the README about moving from version 5.0 to 5.1? |
@rodion-m done 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks a lot for your contribution!
Fixes #27
6.0.0
MultipartFileRecreatable
documentation.MultipartFileRecreatable.fromBytes
factory compatible with web.headers
parameter.MultipartFileRecreatable.data
.MultipartFileRecreatable.filename
is now a named parameter to matchdio
.MultipartFileRecreatable.filePath
since it was not being used internally.