turn off particular tests? .puppet-lintrc?

[pdurbin]

Is it possible to turn off particular tests in puppet-lint? For example, one test is "Should not exceed an 80 character line width" but what if I wanted to disable this test altogether?

In perltidy I do something similar, using the option --noblanks-before-blocks in my .perltidyrc, per the documentation because I don't like the default behavior.

It would be great to have a .puppet-lintrc. Apologies if there already is one and I missed it.

[rodjek]

I'm actually working on the ability to selectively disable checks at the moment, it shouldn't be too long.

[pdurbin]

Great news!

[rodjek]

This is being worked on as part of the modularise branch. Coming real soon now.

[rodjek]

OK, so you can now disable checks! puppet-lint --help to get the check names then just add whatever flags you want to either ~/.puppet-lintrc or a per-project .puppet-lintrc

[rodjek]

Sorry, should mention you'll need to upgrade to 0.1.11

[pdurbin]

Thanks for implementing my feature request! I finally got around to upgrading (jumped up from 0.1.5 to 0.1.12) and it works great! My only suggestion is to document the ability to use ~/.puppet-lintrc in the output of puppet-lint --help.

[rodjek]

Yep, documentation is really lacking. Updating it all and explaining what each warning/error means & how to fix it is a project for a rainy weekend (like this coming one actually).

On Thursday, 2 February 2012 at 6:38 AM, Philip Durbin wrote:

Thanks for implementing my feature request! I finally got around to upgrading (jumped up from 0.1.5 to 0.1.12) and it works great! My only suggestion is to document the ability to use ~/.puppet-lintrc in the output of puppet-lint --help.

---

Reply to this email directly or view it on GitHub:
#34 (comment)

[ccaviness]

I would love the ability to disable particular tests from within the manifest, either on a line-by-line basis on within a block, or both.

Specifically, I want the >80 char check everywhere except on the lines that have our revision control tags, which frequently expand to >80 chars.

[ccaviness]

If you want a new feature request for this, I'd gladly write it up.

[vStone]

I don't think thats gonna be an easy one, since some checks run on the lines while others depend on the tokens. Tokens don't contain comments since those don't get included by the puppet parser by default.

I wanted to write some checks on proper puppet docs so I've run into this barrier before.

[rodjek]

We can access the comments through the lexer's commentstack however it is a bit of a pain in the arse. If in doubt, monkey patch the lexer again.

[rodjek]

To follow up, the way I'd see this potentially working is

1. puppet-lint finds a problem on line n
2. puppet-lint checks for a comment on the line above (Puppet::Parser::Lexer#getcomment)
3. If the comment matches "# skip-check-" (or something similar), don't alert on this infraction.

[ccaviness]

I'm hoping for something like what pylint (http://www.logilab.org/card/pylint_manual) can do, where you put a comment like "# puppet-lint: disable=80chars-check" or similar at the end of a line and it doesn't lint that line for that check. Also able to disable a check for a block of lines by surrounding with "# puppet-lint: disable=whatever" [...] "# puppet-lint: enable=whatever"

[rodjek]

That is going to be rather tricky. As @vStone pointed out earlier, the Puppet parser basically discards any comments in your manifests. It's not impossible though. I'd suggest taking this discussion into a new issue for clarity.

[ccaviness]

#68