fix mutability issue with cache

core/__snapshots__/core.test.js.snap

@@ -468,6 +468,67 @@ Object {
 }
 `;
 
+exports[`test passing optional alias to two entities with opt and non opt works fine with caching 1`] = `
+Object {
+  "rasa_nlu_data": Object {
+    "common_examples": Array [
+      Object {
+        "entities": Array [],
+        "intent": "greet",
+        "text": "hola botname1",
+      },
+      Object {
+        "entities": Array [],
+        "intent": "greet",
+        "text": "hola botname2",
+      },
+      Object {
+        "entities": Array [],
+        "intent": "greet",
+        "text": "hola",
+      },
+      Object {
+        "entities": Array [],
+        "intent": "greet",
+        "text": "buenas botname1",
+      },
+      Object {
+        "entities": Array [],
+        "intent": "greet",
+        "text": "buenas botname2",
+      },
+      Object {
+        "entities": Array [],
+        "intent": "greet",
+        "text": "buenas",
+      },
+      Object {
+        "entities": Array [],
+        "intent": "goodbye",
+        "text": "chao botname1",
+      },
+      Object {
+        "entities": Array [],
+        "intent": "goodbye",
+        "text": "chao botname2",
+      },
+      Object {
+        "entities": Array [],
+        "intent": "goodbye",
+        "text": "adios botname1",
+      },
+      Object {
+        "entities": Array [],
+        "intent": "goodbye",
+        "text": "adios botname2",
+      },
+    ],
+    "entity_synonyms": Array [],
+    "regex_features": Array [],
+  },
+}
+`;
+
 exports[`test pegjs parser output 1`] = `
 "[
   {

core/core.test.js

@@ -411,3 +411,26 @@ test("test passing optional alias once and once not and caching works", () => {
     expect(error).toBeNull();
     expect(result).toMatchSnapshot();
 });
+
+test("test passing optional alias to two entities with opt and non opt works fine with caching", () => {
+    let error = null;
+    let result = null;
+    const input = `
+%[greet]
+    hola ~[bot?]
+    buenas ~[bot?]
+
+%[goodbye]
+    chao ~[bot]
+    adios ~[bot]
+
+~[bot]
+    botname1
+    botname2
+`;
+    try {
+        result = generator.datasetFromString(input, "rasa");
+    } catch (e) { error = e; }
+    expect(error).toBeNull();
+    expect(result).toMatchSnapshot();
+});

core/datasetGenerator.js

@@ -143,7 +143,7 @@ function getVariationsFromEntity(e, defs, parentEntity, isTheOnlyEntityOfASenten
     }
     let variations = [];
     if (cache[e.type] && cache[e.type][e.id]) {
-        variations = cache[e.type][e.id];
+        variations = [].concat(cache[e.type][e.id]);
     } else {
         sentences.forEach(s => {
             variations = variations.concat(getVariationsFromSentence(s, defs, null, e, cache));

package.json

@@ -1,6 +1,6 @@
 {
   "name": "chatito",
-  "version": "1.2.1",
+  "version": "1.2.2",
   "description": "Generate training datasets for slot filling chatbots in a breeze using a simple DSL",
   "bin": {
     "chatito": "./bin/chatito.js"