Crash when using custom colors

[su-v]

Lastest inklinkgreader crashes on OS X if either a config file is present, or colors (for background, or for the pen) are specified on the command line.

$ gdb inklingreader
GNU gdb 6.3.50-20050815 (Apple version gdb-1752) (Sat Jan 28 03:02:46 UTC 2012)
Copyright 2004 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB.  Type "show warranty" for details.
This GDB was configured as "x86_64-apple-darwin"...Reading symbols for shared libraries ................... done

(gdb) r --colors="#000000,#ff0000,#0000ff,#00ff00" --file ./tree.WPI --to ./tree-colors.svg
Starting program: /Users/su_v/.local/bin/inklingreader --colors="#000000,#ff0000,#0000ff,#00ff00" --file ./tree.WPI --to ./tree-colors.svg
Reading symbols for shared libraries ++++++++++++++++++.......................................................................................................................................................... done
inklingreader(29096) malloc: *** error for object 0x10101c928: pointer being freed was not allocated
*** set a breakpoint in malloc_error_break to debug

Program received signal SIGABRT, Aborted.
0x00007fff88d0782a in __kill ()
(gdb) bt full
#0  0x00007fff88d0782a in __kill ()
No symbol table info available.
#1  0x00007fff8dafaa9c in abort ()
No symbol table info available.
#2  0x00007fff8db5984c in free ()
No symbol table info available.
#3  0x0000000100006ae9 in dt_configuration_cleanup (config=0x1000096d0) at src/datatypes/configuration.c:86
    a = 1
#4  0x0000000100001c60 in cleanup_configuration () at src/main.c:102
No locals.
#5  0x00007fff8dafa7d0 in __cxa_finalize ()
No symbol table info available.
#6  0x00007fff8dafa652 in exit ()
No symbol table info available.
#7  0x000000010000165b in start ()
No symbol table info available.
(gdb) 

Sample inklingreaderrc file which triggers the same type of crash:

background = #efefef
colors = #729fcf,#999999,#ff8080,#cccccc
pressure-factor = 1.0

[roelj]

Should be resolved now.

[su-v]

'--colors' is ok with latest, but '--background' not yet (sorry for running incomplete tests before writing the issue):

(gdb) r --background="#ffffff"  --file ./test/tree.WPI --to ./test/tree-background.svg
Starting program: /Users/su_v/.local/bin/inklingreader --background="#ffffff"  --file ./test/tree.WPI --to ./test/tree-background.svg
Reading symbols for shared libraries ++++++++++++++++++.......................................................................................................................................................... done
inklingreader(65026) malloc: *** error for object 0x7fff5fbff83e: pointer being freed was not allocated
*** set a breakpoint in malloc_error_break to debug

Program received signal SIGABRT, Aborted.
0x00007fff88d0782a in __kill ()
(gdb) bt full
#0  0x00007fff88d0782a in __kill ()
No symbol table info available.
#1  0x00007fff8dafaa9c in abort ()
No symbol table info available.
#2  0x00007fff8db5984c in free ()
No symbol table info available.
#3  0x0000000100006b69 in dt_configuration_cleanup (config=0x1000096d0) at src/datatypes/configuration.c:104
No locals.
#4  0x0000000100001bd0 in cleanup_configuration () at src/main.c:102
No locals.
#5  0x00007fff8dafa7d0 in __cxa_finalize ()
No symbol table info available.
#6  0x00007fff8dafa652 in exit ()
No symbol table info available.
#7  0x00000001000015cb in start ()
No symbol table info available.
(gdb) q

[roelj]

That should be fixed now as well.

[su-v]

Yep, thx a lot :)