-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Results no longer displaying #75
Comments
Is the 1.2 version still working for you? In my setup latest version does run the speedtest (with the same invalid date error you have) but results are written correctly as the 1.2 version can show those results in the graph |
Had the same issue, and did some research. In evaluation.js the processing of the timestamps fails. I guess the structure of the row.data[0] object of the Papa.parse has changed. Changing the row.data[0] to row.data resolved the issue for me. I hope that information helps. |
I also have the issue with the results not showing in the graph. |
Same here. Using the docker container and manually fixed it there as a temporary workaround - changed row.data[0] to row.data and all is working again. |
Changed line 93 row.data[0] to row.data as per roest01#75
Hi there, I found the file and edited the row but still not joy. Did i miss something else I needed to do? |
What I found out was to clear the cache of the browser. Then do a refresh. Did you do this? |
That did the trick… I just tried an incognito mode and yes i can see it now! Thanks so much for your tips! |
Awesome ! Weird enough I am having the issue that the tester does not automatically run , it does it sporadically. So I have a 11am, then again 1pm, then again 3pm , then again 9pm. |
Just spun this up and I'm seeing no results either. Incognito mode/clearing the cache doesn't help. Is the PR going to be merged and a new release pushed out soon, or do I need to manually hack the js per the comments above? Edit: Hacked the js per the PR to remove the '[0]' and it's working now. :) |
I just did this and it looks like the file is able to be written but it has 0 content inside it? It's blank (fresh fresh copy)? |
That's weird that there is no content. These are the steps I use: Open Docker -> open the docker container -> goto terminal -> create -> bash windows opens In terminal -> cd /var/www/html/js go to line Papa.parse("data/result.csv", { See if this works |
Sorry I apologise, I mean "I've just done this" as in I've re-run a fresh container. I have not edited the contents of an existing one and I have a script, which stops, deletes, pulls fresh and re-spins all my containers once a week, so as soon as I commit a change to fix this one problem, a week later it will break again. I suspect the fix needs to be done by roest01 |
Ah ok gotcha. |
I've actually mapped out /var/www/html/js into my filesystem. -v /dockerconfigs/speedtestanalyzer/js:/var/www/html/js I've copied the contents of the files into here and about 2/3 down in the .js text file I removed the [0] and it has not worked. |
Great idea to map it to your filesystem and interesting that the fix doesn't work for you. |
So is this over and done with? |
I guess this is dead. Thsi is a shame, my replacement just stuffed up too. |
I never got it to work again.. It's still collecting data but won't display at all. |
Need only edit a single file but it's awkward to do unfortunately. |
yes I did the edit as well, didn't work for me either. |
Thanks, I thought I was an idiot, being unable to figure it out! - Maybe someone sharp made a good fork of it, I havne't checked that. |
This continues to work for me. Note the It is line 93 of the original file: https://github.com/roest01/docker-speedtest-analyser/blob/master/js/evaluation.js#L93 To get into the shell of the running docker container execute the command |
I'm honestly not super super dumb, with linux, I promise but I had real issues with this. I think VI is not fun to work with, however I did manage to edit the ghastly thing and it still didn't work for me. I wonder if someone can just spin off a fork of it, that's fixed? (is it that simple? I don't actually 'get' forks yet) |
I updated the container image I was using and see the results not flowing anymore as well. Looking at the logs the actual speetest python commands were erroring out. I was able to resolve this by going into the container and executing |
sadly that didn't work for me. it's still running and recording results, it's just not displaying the results. I checked the results.csv and it's writing the results. |
I'm glad people are discussing this again at least, thanks for the help. I suspect even if I nuke the container and the data, it'll still be broken. |
If anyone finds a fork of this project that is still alive, please let us
know here. I loved the simplicity of this, but the project seems to have
gone dead.
…On Tue, 7 Sept 2021 at 04:48, jaxjexjox ***@***.***> wrote:
I'm glad people are discussing this again at least, thanks for the help.
My chart is full of "invalid date" all through it to be honest.
I suspect even if I nuke the container and the data, it'll still be broken.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#75 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGFIE76FEZQXDAF2XQEQAQLUAV4QNANCNFSM43LODG7Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
You want: |
Here are the lists of all the forks? Does anyone know how to check which one is the best or most updated? |
This worked for me: remove the [0] from the row.data[0] |
I've edited the file again, the package is literally not writing out to /var/www/html/data, where it's supposed to store the csv (??) file which contains the tests. Do I need to stop and start the container or something? |
That’s exactly what I have done and it still doesn’t work. There is something else wrong seomwhere.
From: pdchristian ***@***.***>
Sent: Wednesday, 29 September 2021 07:37
To: roest01/docker-speedtest-analyser ***@***.***>
Cc: monty974 ***@***.***>; Author ***@***.***>
Subject: Re: [roest01/docker-speedtest-analyser] Results no longer displaying (#75)
That's weird that there is no content.
These are the steps I use:
Open Docker -> open the docker container -> goto terminal -> create -> bash windows opens
In terminal -> cd /var/www/html/js
vi evaluation.js
go to line Papa.parse("data/result.csv", {
There you will find the line
let dataArr = row.data;
See if this works
This continues to work for me. Note the let dataArr = row.data; is the correction. The original line looks like this: let dataArr = row.data[0];
It is line 93 of the original file: https://github.com/roest01/docker-speedtest-analyser/blob/master/js/evaluation.js#L93
To get into the shell of the running docker container execute the command docker exec -it <containername> sh. From there the cd / and vi commands will work.
I'm honestly not super super dumb, with linux, I promise but I had real issues with this. I think VI is not fun to work with, however I did manage to edit the ghastly thing and it still didn't work for me.
I wonder if someone can just spin off a fork of it, that's fixed? (is it that simple? I don't actually 'get' forks yet)
This worked for me: remove the [0] from the row.data[0]
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#75 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AP2UAUANRCP377FZLJ7UAJLUEIYQFANCNFSM43LODG7Q> .
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub> . <https://github.com/notifications/beacon/AP2UAUBH3KOUU4ANDFM2SPDUEIYQFA5CNFSM43LODG72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOG5UT2UI.gif>
|
Since this project seems to be dead and no longer functioning properly (at least for many/most), and people are looking for alternatives I thought I'd mention this project. https://github.com/henrywhitaker3/Speedtest-Tracker I've been using this for a few months. It seems to work really well and I personally prefer the dashboard there plus there is influxdb integration if you use Grafana dashboards. |
Thanks @JacobOkanta I've posted that one beofre too, there's plotter and tracker. ansemjo/speedtest Mind you tracker did have a bug recently that took a few weeks to fix. Maybe the poor fella died of covid or something. |
I followed this and it resolved the issue for me. I had to remember to use Private Window in order to see the change since Safari was caching the original result. Thanks!! |
@marchos77 Several people have done this, via multiple methods and it hasn't worke.d I've edited it within the container, I've used SMB to put the file outside the container and edit it via nano or even Windows. Someone please just needs to write a fork. It's still the best looking speedtest. |
Make sure your mapped As far as the invalid date, I got it fixed as suggested (by removing the For ease, I copied
Where My data folder listing looks like this:
Where The only thing that remains yet to be seen is if the crontab will actually run on the hour. From what I can tell, it might not. I got these results by running manually. Update: The cronjob does does not work when invoked by the crontab. I get this:
I am suspecting that the user context is wrong (it is running under Last update: The cron does work, but intermittently. At least I have data points through the day, that should be enough for me. |
You could just switch to tracker or plotter, sadly this one is abandoned. |
Found a pretty nice one: https://awesomeopensource.com/project/henrywhitaker3/Speedtest-Tracker |
Also this one. Analyser isn't worth the effort in fixing it. |
My speedtest has been working solidly for over a year now, however from saturday or so it stopped displaying. doesn't matter what i do the graph draws but no results come up. I have tried deleting the results.csv to create a new one but now it says "invalid date" on the x axis. I pulled the latest version to see if that fixed it but no luck
results are being written to the file, but not sure if there is an issue with the way it gets written.
result.zip
The text was updated successfully, but these errors were encountered: