Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to label the fragment type of NIST20? #1

Closed
JosieHong opened this issue Dec 16, 2021 · 2 comments
Closed

How to label the fragment type of NIST20? #1

JosieHong opened this issue Dec 16, 2021 · 2 comments

Comments

@JosieHong
Copy link

JosieHong commented Dec 16, 2021

Hi,

Thanks for the great work! When I tried to implement it on my server, I met some problems with splitting the data of 'HCD' and 'CID'.

Following the instructor in README, I exported lr_msms_nist and hr_msms_nist of NIST20. However, after parse_and_export.py, the fragment type (frag_mode) of them is NaN. So how do you label the fragment type of them?

Thanks,
Josie

@JosieHong JosieHong changed the title Which subset of NIST20 need to be exported, in the experiments? How to label the fragment type of NIST20? Dec 21, 2021
@adamoyoung
Copy link
Contributor

adamoyoung commented Oct 6, 2023

Hi Josie,

Sorry for the super (super) late reply, I somehow missed this issue.

When we processed the data, we only used spectra from the hr_nist_msms (high resolution) partition. I haven't tested the lr_nist_msms (low resolution) partition recently, so our preprocessing script might not work properly on those data.

However, looking at the lr_nist_msms.MSP file that I have, it seems to me like they do not include the "Frag_mode" metadata entries, which would explain your NaNs. Based on the context of this data, I think it's safe to assume they are all "CID". However, I do think there is a high degree of overlap between the low resolution and high resolution libraries, so I'm not sure how useful it will be to include these spectra in the training data.

@JosieHong
Copy link
Author

I see. I will try hr_nist_msms first. Thanks a lot! ; )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants