Memoized renderRule #146
Merged
Memoized renderRule #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the same style object is passed to a Prefix instance, a cached value is returned. A WeakMap is used so the cache does not aggressively hold on to referenced style objects.
TheUltDev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the same style object is passed to
renderRule, a previously computed className is returned. A WeakMap is used so the cache does not aggressively holdon to referenced style objects.
I'm not sure how much real world performance increase this will have overall, but it's certainly better in theoretical tests. A 10000x loop going from
540ms~to2ms~.This should work well with projects that already use an immutable flow, but then again those components shouldn't be re-rendering in the first place if the props haven't changed.