Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/no bash db installation trial #83

Merged
merged 17 commits into from
Sep 5, 2018

Conversation

rogalmic
Copy link
Owner

Branch to test extension that requires no bashdb installation. This will help with keeping proper bashdb version installed.

I contacted creator of bashdb, some issues with spaces in path have been fixed.

@rogalmic rogalmic requested a review from wataash August 30, 2018 13:24
@rogalmic
Copy link
Owner Author

@wataash : would it be possible for you to test this branch under macOS?

@rogalmic rogalmic force-pushed the feature/noBashDbInstallationTrial branch from 51f26c9 to 643fd97 Compare August 30, 2018 14:20
@rogalmic rogalmic force-pushed the feature/noBashDbInstallationTrial branch from 643fd97 to 2dc0436 Compare August 30, 2018 14:34
@rogalmic
Copy link
Owner Author

rogalmic commented Aug 30, 2018

Test package:
bash-debug-0.2.4.vsix.zip

- better immidiate window functionality
- handle chmod error
@wataash
Copy link
Collaborator

wataash commented Aug 31, 2018

@rogalmic
Good job 👍
I really want to test and review this PR, but currently I have very limited time to working on this project.
I think I'll do testing on macOS in a week, but feel free to merge it whenever you want.

@rogalmic
Copy link
Owner Author

OK, thanks!

@rogalmic rogalmic force-pushed the feature/noBashDbInstallationTrial branch 2 times, most recently from a2ade74 to 6d1356d Compare August 31, 2018 16:51
@rogalmic rogalmic force-pushed the feature/noBashDbInstallationTrial branch from 6d1356d to 767c310 Compare August 31, 2018 19:07
@rogalmic rogalmic merged commit 60da4a8 into master Sep 5, 2018
@rogalmic rogalmic deleted the feature/noBashDbInstallationTrial branch September 29, 2018 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants