Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ignoring {} by using $ #38

Merged
merged 1 commit into from
Dec 6, 2020
Merged

Allow ignoring {} by using $ #38

merged 1 commit into from
Dec 6, 2020

Conversation

roggervalf
Copy link
Owner

This PR is trying to fix #37, now you can pass for example:

expect(braceExpand('${13}')).toMatchObject(['{13}']);
expect(braceExpand('${13}$${ab}')).toMatchObject(['{13}${ab}']);
expect(braceExpand('${13}a$b${ab}')).toMatchObject(['{13}a$b{ab}']);

@roggervalf
fix(matcher): allow ignoring {} by using $, ie ${a} should match with…
9501549 
… {a}

there is a refactor too, trying to separate braceExpand logic in a utility function

fix #37
@roggervalf roggervalf added the bug Something isn't working label Dec 6, 2020
@roggervalf roggervalf merged commit 470f07d into master Dec 6, 2020
@roggervalf roggervalf deleted the fix/braceExpand branch December 6, 2020 00:03
@roggervalf
Copy link
Owner Author

🎉 This PR is included in version 4.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow ignore {} in pattern when braceExpand
1 participant
@roggervalf