#4414 implement Set #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonbartels
reviewed
Aug 30, 2023
|
|
||
| private Map<String, Integer> destinationIdMap; | ||
| private Map<String, Integer> destinationIdMap = Collections.emptyMap(); | ||
| private Set<Integer> metaDataIds; |
There was a problem hiding this comment.
Should this also default to Collections.emptySet() ?
There was a problem hiding this comment.
No, as we use its add() which emptySet() doesn't implement
| @@ -43,6 +47,7 @@ public DestinationSet(ImmutableConnectorMessage connectorMessage) { | |||
| this.metaDataIds = (Set<Integer>) connectorMessage.getSourceMap().get(Constants.DESTINATION_SET_KEY); | |||
| } | |||
| } catch (Exception e) { | |||
| metaDataIds = new HashSet<>(); | |||
There was a problem hiding this comment.
Is the catch block even necessary here?
There was a problem hiding this comment.
In the rare case of a ClassCastException when pulling out the SourceMap. Until they fix that, it's worth leaving.
server/src/com/mirth/connect/server/userutil/DestinationSet.java
Outdated
Show resolved
Hide resolved
| assertEquals(4, ds.size()); | ||
| assertTrue(ds.addAll(Arrays.asList(5, 6))); | ||
| assertEquals(6, ds.size()); | ||
| //TODO is this what we want? |
There was a problem hiding this comment.
I think so. The behavior of DestiationSet is such that if any operation fails, it returns false
| assertFalse(ds.containsAll(Arrays.asList("Invalid"))); | ||
| assertFalse(ds.containsAll(Collections.singleton(null))); | ||
| //TODO is this what we want? | ||
| assertFalse(ds.containsAll(null)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have TODOs in the tests which welcome feedback involving what should happen when nulls are passed to various functions.