Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aria-labelledby #164

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Add aria-labelledby #164

merged 2 commits into from
Nov 15, 2023

Conversation

roginfarrer
Copy link
Owner

Missing the recommended aria-labelledby attribute according to https://www.w3.org/WAI/ARIA/apg/patterns/accordion/

Optionally, each element that serves as a container for panel content has role region and aria-labelledby with a value that refers to the button that controls display of the panel.

Copy link

changeset-bot bot commented Nov 15, 2023

🦋 Changeset detected

Latest commit: 054b149

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-collapsed Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for react-collapsed ready!

Name Link
🔨 Latest commit 054b149
🔍 Latest deploy log https://app.netlify.com/sites/react-collapsed/deploys/655555a528db4a000835cc8f
😎 Deploy Preview https://deploy-preview-164--react-collapsed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@roginfarrer roginfarrer merged commit cc68b19 into main Nov 15, 2023
5 checks passed
@roginfarrer roginfarrer deleted the missing-aria-labelledby branch November 15, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant