Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase pagination max-limit to 150. #5

Closed
RohitKaushal7 opened this issue Aug 15, 2020 · 2 comments
Closed

increase pagination max-limit to 150. #5

RohitKaushal7 opened this issue Aug 15, 2020 · 2 comments

Comments

@RohitKaushal7
Copy link
Contributor

please increase pagination limit to 150, as now there are usually more then 100 students in one class so it would need two fetch requests to the API to fetch the result of 105 students. which could have been done in one.

api/result/student?branch=cse&roll=18%&limit=150

also can there be an api endpoint to fetch the results of a class like..
api/result/student?branch=cse&year=2018

current hack is..
api/result/student?branch=cse&roll=18%

which works perfectly fine but.

RohitKaushal7 added a commit to RohitKaushal7/nithp that referenced this issue Aug 15, 2020
@RohitKaushal7
Copy link
Contributor Author

RohitKaushal7 commented Aug 15, 2020

Actually can we make it around 3000. :)

I mean what if someone needs whole data college data in 1 request.. otherwise it needs 30 requests again and again which is very slow.. 😄

@rohithill
Copy link
Owner

I have updated the limit to 1000.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants