fix LTSV formatter to split by hard tab not string '\t' #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,4 +24,8 @@ | |||
| it 'escapes escape sequences as value' do | |||
| expect(subject).to include('will_escaped:\\t') | |||
| end | |||
|
|
|||
| it 'should be splitted by tab' do | |||
There was a problem hiding this comment.
Can we change this to more definitive language, perhaps it 'is separated by hard tabs' do?
bonty
force-pushed
the
fix-ltsv-formatter
branch
from
15784f3
to
2bedb81
Compare
|
@benlovell Thank you for your review! I've rebased and fixed code that you pointed out. |
|
Thanks ❤️ |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I found LTSV formatter split values by string '\t' not hard tab.
I fixed it and write some spec.
Thanks.