End support for Ruby 1.9.3 and Rails 3 #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop building against Ruby 1.9.3 in readiness to end support.
Ending support for Rails 3 since it will now only receive patches for severe security issues, and in readiness for supporting Rails 5.
|
But even rails 4 supports 1.9.3 as minimum version 😢 |
|
@isqad88 Internally, this project hasn't changed much over the years and given we're a pretty lightweight dependency, I suspect you could happily use the current released version |
|
@pxlpnk Any thoughts before I merge? |
|
We are not trying to rely on 1.9.3 features. The code in general is more focused on rails than on ruby. I am even pretty sure that lograge runs with all 1.9 rubies. However to slim down our dependencies we should move forward and leave 1.9.3 behind. 👋 😭 |
benlovell
added a commit
that referenced
this pull request
Feb 15, 2016
End support for Ruby 1.9.3 and Rails 3
benlovell
added a commit
that referenced
this pull request
Feb 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ends support for the now unsupported Ruby 1.9.3 and the semi-supported
("severe" security fixes only) Rails 3.2.
This is in readiness for our support of Rails 5, and also to decrease the
support burden for increasingly uncommon configurations.