copy source image docs #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mweibel
reviewed
Mar 6, 2018
source/_references/sourceimages.md
Outdated
| you can do a `COPY` request to `/sourceimages/{org}/{hash}` and send the `Destination` header with the destination organization. | ||
| If you send a `Overwrite: F` header with it, it won't copy it, if it already exists at the destination. | ||
| Your API user needs to have read permissions on the source organization and write permissions on the destination organization. | ||
| The [memberships endpoint](memberships.html) has methods to give an API user access to more organizations, |
There was a problem hiding this comment.
organizations, -> organizations.
thePanz
reviewed
Mar 28, 2018
source/_references/sourceimages.md
Outdated
| Returns a 404 http code, if the source image was not found. | ||
|
|
||
| ```language-bash | ||
| curl -X POST -H 'Destination: mycompany-stage' 'https://api.rokka.io/sourceimages/mycompany/c412d8d6e4b9b7b058320b06972ac0ec72cfe6e5' |
There was a problem hiding this comment.
Shouldn't be curl -X COPY -H ... ?
thePanz
reviewed
Mar 28, 2018
source/_references/sourceimages.md
Outdated
| Returns a 201 http code, if the image was newly created at the destination. | ||
| Returns a 204 http code, if the image was overwritten at the destination. | ||
| Returns a 412 http code, if `Overwrite: F` was sent and the destination exists already. | ||
| Returns a 404 http code, if the source image was not found. |
There was a problem hiding this comment.
Do we return a 400 if the destination organization does not exist?
There was a problem hiding this comment.
Do we return a 403 if the user has no write permissions on Destination org?
There was a problem hiding this comment.
Both added and the rest is adjusted too, thank
thePanz
reviewed
Mar 28, 2018
source/_references/sourceimages.md
Outdated
| ## Restore a source image | ||
|
|
||
| To restore a deleted image, do a `POST`request to `/sourceimages/{org}/{hash}/restore`. | ||
| To restore a deleted image, do a `POST` request to `/sourceimages/{org}/{hash}/restore`. |
There was a problem hiding this comment.
There are two (spaces) before __do
chregu
force-pushed
the
copy-sourceimage
branch
from
d51aac7
to
eb1377c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend is deployed