Prevent overwriting the Program._manifest if already set on startup (#…

…1027)
rokucommunity · Jan 24, 2024 · f773d92 · f773d92
1 parent 1b948c5
commit f773d92
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/Program.ts b/src/Program.ts
@@ -1385,8 +1385,13 @@ export class Program {
     /**
      * Try to find and load the manifest into memory
      * @param manifestFileObj A pointer to a potential manifest file object found during loading
+     * @param replaceIfAlreadyLoaded should we overwrite the internal `_manifest` if it already exists
      */
-    public loadManifest(manifestFileObj?: FileObj) {
+    public loadManifest(manifestFileObj?: FileObj, replaceIfAlreadyLoaded = true) {
+        //if we already have a manifest instance, and should not replace...then don't replace
+        if (!replaceIfAlreadyLoaded && this._manifest) {
+            return;
+        }
         let manifestPath = manifestFileObj
             ? manifestFileObj.src
             : path.join(this.options.rootDir, 'manifest');

diff --git a/src/ProgramBuilder.ts b/src/ProgramBuilder.ts
@@ -504,7 +504,7 @@ export class ProgramBuilder {
             }
 
             if (manifestFile) {
-                this.program!.loadManifest(manifestFile);
+                this.program!.loadManifest(manifestFile, false);
             }
 
             const loadFile = async (fileObj) => {