Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for onChange function #941

Merged
merged 5 commits into from
Dec 18, 2023
Merged

Add check for onChange function #941

merged 5 commits into from
Dec 18, 2023

Conversation

MilapNaik
Copy link
Collaborator

@MilapNaik MilapNaik commented Nov 3, 2023 •
edited by TwitchBronBron
Loading

Issue: #939

Add check for onChange functions in xml files

image

TwitchBronBron
TwitchBronBron approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for this, and sorry for the slow response on reviewing this.

@TwitchBronBron TwitchBronBron merged commit 02f0de9 into master Dec 18, 2023
6 checks passed
@TwitchBronBron TwitchBronBron deleted the check-onChange-funcs branch December 18, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwitchBronBron TwitchBronBron TwitchBronBron approved these changes

@chrisdp chrisdp Awaiting requested review from chrisdp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MilapNaik @TwitchBronBron