Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and command enhancements #6

Merged
merged 7 commits into from
Oct 9, 2018
Merged

Build and command enhancements #6

merged 7 commits into from
Oct 9, 2018

Conversation

johndistasio
Copy link

@johndistasio johndistasio commented Oct 9, 2018

Suggesting some updates here:

  1. Add a stats subcommand for the cluster API.
  2. Allow for extra args to cluster/state and node/stats for filtering output.
  3. Use dep instead of go get. I think Dep is still the closest thing to "the" Go package manager; modules still seem to be a work-in-progress.
  4. Use the current import path for the cli package.
  5. Change build command to force a static binary.

@rolinh
Copy link
Owner

rolinh commented Oct 9, 2018

Hi @johndistasio,

Thanks you for your contributions; there's a lot of cool stuff in there :)
About 3., yes, I think think that Dep is the closest thing to the "Go package manager" for now, until modules (vgo) has matured.

@rolinh rolinh merged commit da3a789 into rolinh:master Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants