Added typing / comments to the SenderInterface
#592
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR adds better typing and comments to the
SenderInterface
to make implementation less error prone. I also updated our three sender classes to properly implement the interface.I removed the
SenderInterface::toString()
method from the interface as well as all the classes that implement it. As best I can tell have not used thetoString()
method since we removed the internal debug logger inv1.6.3
.Type of change
Related issues
None
Checklists
Development
Code review