Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added typing / comments to the SenderInterface #592

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

danielmorell
Copy link
Collaborator

Description of the change

This PR adds better typing and comments to the SenderInterface to make implementation less error prone. I also updated our three sender classes to properly implement the interface.

I removed the SenderInterface::toString() method from the interface as well as all the classes that implement it. As best I can tell have not used the toString() method since we removed the internal debug logger in v1.6.3.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

None

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@danielmorell danielmorell added the Type: Maintenance General up-keep, or changes that tidy an existing component or process. label Jan 9, 2023
@danielmorell danielmorell added this to the v4.0.0 milestone Jan 9, 2023
Copy link
Contributor

@waltjones waltjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@danielmorell danielmorell merged commit 48e151c into next/4.0/main Jan 12, 2023
@danielmorell danielmorell deleted the 4.0/updated-sender-interface branch January 12, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance General up-keep, or changes that tidy an existing component or process.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants