Updated the object serialization logic and removed deprecation warning #605
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This commit cleans up the object serialization logic. Notably, it removes a deprecation warning that really should never have been there in the first place. I feel free to say that because I am the one who put it there. It mirrors the built in deprecation warning that PHP itself gives and is unnecessary.
We have split the serialization into internal and external logic we can easily ensure we are correctly serializing each object.
I also added a few comments to explain some of the bits of code that are not obvious.
Type of change
Related issues
None
Checklists
Development
Code review