Updated test dependencies to fix generated mock class type annotation error #627
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This update increases our minimum required dependencies for two of our test dependencies:
phpunit/phpunit
andmockery/mockery
. Without this we see the following error when trying to install and test the lowest versions of all of our dependencies. See #624 for the failing test results.Updating only
mockery/mockery
solves the above issue. However, it introduces a new one. The mock generated from theData
class in...https://github.com/rollbar/rollbar-php/blob/e7bb5f91921baf4a0e9d08e510c7791aa22b0d5a/tests/VerbosityTest.php#LL397C1-L399C1
Results in one of the generated methods having a type annotation both a
?
and|null
which is invalid and causes a fatal error during the test run. By updating our version ofphpunit/phpunit
that issue is resolved.Type of change
Related issues
None
Checklists
Development
Code review