quick and dirty fix to issue #45 #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since this is an officials best practice/paperwork requirement, I am adding this as a stopgap while I work on converting the penalty code definition to something based on a runtime-loaded file and less copy-and-paste terrible (like an "is expellable" flag on a penalty definition).
| updateMap.put("PenaltyCode.FO_EXP(EXP-D)", "Expulsion-Direction"); | ||
| updateMap.put("PenaltyCode.FO_EXP(EXP-P)", "Expulsion-Illegal Position"); | ||
| updateMap.put("PenaltyCode.FO_EXP(EXP-N)", "Expulsion-Interference"); | ||
| updateMap.put("PenaltyCode.FO_EXP(EXP-G)", "Expulsion-Misconduct"); |
There was a problem hiding this comment.
Should we add unknown too? It seems unlikely to come up, but it's possible.
There was a problem hiding this comment.
I would add unknown for the sake of it
There was a problem hiding this comment.
Yeah, it's worth it for consistency I think.
There was a problem hiding this comment.
Can you add it to your pull so when I merge or Jared does we can capture it?
There was a problem hiding this comment.
I can create a quick PR after you merge for the sake of simplicity. My PR is big enough as-is.
There was a problem hiding this comment.
Actually, better idea. #62 contains both @official-sounding's commit and this change so you can merge or rebase that one, and close this one.
JeneralPain
approved these changes
May 31, 2018
jaredquinn
added a commit
that referenced
this pull request
Jun 6, 2018
…and-unknown PR #52 with unknown expulsion code added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes Issue #45 by adding EXP-* codes to the FO_EXP list of penalties, with a subset of penalties that are expellable.
Since this is an officials best practice/paperwork requirement, I am adding this as a stopgap while I work on converting the penalty code definition to something based on a runtime-loaded file and less copy-and-paste terrible, like an "can expel" flag on a penalty definition.