This repository has been archived by the owner on Jan 16, 2018. It is now read-only.
Refactor Column data-mapping and configuration #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To newcomers it's very unclear how data-mapping actually works, and it's over complicated.
So instead the data-providing part is moved to the column itself, where the developer sets a callable to to extract the data from the data for the row.
And to improve DX, when no data_provider is configured the system tries to build one itself (Uses column-name, checks for array-access, property access and getter as last).
Further:
These changes make the column easier to use, and removes some YAGNI 👍