This repository has been archived by the owner on Jan 16, 2018. It is now read-only.
Refactor text formatting #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sstok
changed the title
sstok
added a commit
that referenced
this pull request
Feb 1, 2016
This PR was merged into the master branch. Discussion ---------- |Q |A | |--- |---| |Bug Fix? |no | |New Feature? |yes| |BC Breaks? |yes| |Deprecations?|no | |Fixed Tickets| | * The ModelType is removed as this can be easily by done by using the TextType with multiple fields and the CompoundColumnType to combine them. * The TrimTransformer is removed as this can be solved with transformer callback and user-input is not longer processed by this system. * The empty value handling is moved to its own Transformer `EmptyValueTransformer`. * The `NestedListTransformer` is removed as the ModelType is no longer supported. Commits ------- ca60e22 Remove trim options and TrimTransformer b2dca34 Remove ModelType as there are better ways of doing this ddf1e4c Split ValueFormatTransformer to reduce complexity ba89aea Update UPGRADE instructions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EmptyValueTransformer.NestedListTransformeris removed as the ModelType is no longer supported.