This repository has been archived by the owner on Jan 16, 2018. It is now read-only.
Introduce Datagrids for creating DatagridFactories #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sstok
commented
Sep 23, 2016
| * | ||
| * @return DatagridFactoryBuilder | ||
| */ | ||
| public function addTypes(array $types) |
| * | ||
| * @return DatagridFactoryBuilder | ||
| */ | ||
| public function addTypeExtensions(array $typeExtensions) |
| * | ||
| * Normally you should not do this, but as this the only | ||
| * way to test if the object is properly build. | ||
| * Else the test would be overly complex. |
The Datagrids class works a facade, it hides a great deal of the implementation details and makes it much easier for none Framework users to create a DatagridFactory with custom extensions, types and type extensions.
sstok
added a commit
that referenced
this pull request
Sep 23, 2016
This PR was merged into the master branch. Discussion ---------- |Q |A | |--- |---| |Bug Fix? |no | |New Feature? |yes| |BC Breaks? |no | |Deprecations?|no | |Fixed Tickets|#8 | The `Datagrids` class works a facade, it hides a great deal of the implementation details and makes it much easier for none Framework users to create a DatagridFactory with custom extensions, types and type extensions. I decided not to add an interface for the DatagridFactoryBuilder class as anyone needing a custom implementation will use a fully custom implementation (KISS 😋). Documentation is coming, but the PHPDoc should already explain how to use this. Commits ------- fb59933 Introduce Datagrids for creating DatagridFactories
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Datagridsclass works a facade, it hides a great deal of the implementation details and makes it much easierfor none Framework users to create a DatagridFactory with custom extensions, types and type extensions.
I decided not to add an interface for the DatagridFactoryBuilder class as anyone
needing a custom implementation will use a fully custom implementation (KISS 😋).
Documentation is coming, but the PHPDoc should already explain how to use this.